Skip to content

Use list queries for folders/bookmarks in macro step selection#657

Merged
multiplex55 merged 1 commit intomasterfrom
codex/update-macro-step-selection-for-bookmarks-and-folders
Jan 8, 2026
Merged

Use list queries for folders/bookmarks in macro step selection#657
multiplex55 merged 1 commit intomasterfrom
codex/update-macro-step-selection-for-bookmarks-and-folders

Conversation

@multiplex55
Copy link
Copy Markdown
Owner

Motivation

  • Surface actual bookmark and folder entries in the macro step picker instead of showing "add/remove" commands.
  • Ensure selected macro steps resolve to the real bookmark URL or folder path rather than an add/remove action.
  • Preserve the user's filter input by passing self.add_filter into the list queries.
  • Provide parity for folders by adding explicit support for a f list command.

Description

  • Updated src/gui/macro_dialog.rs to call plugin.search(&format!("f list {}", self.add_filter)) for folders and plugin.search(&format!("bm list {}", self.add_filter)) for bookmarks when building the macro action list.
  • Added a list_entries helper, LIST_PREFIX handling, and a new f list command in src/plugins/folders.rs so folder list queries return folder paths (not add/remove actions).
  • Kept the existing query: resolution logic so when a command action is a query: it is resolved via plugin.search and the resolved action/args are stored in the created MacroStep.
  • Passed the current self.add_filter into the new list queries to retain previous filtering behavior.

Testing

  • No automated tests were executed for this change.
  • Existing unit tests in the repository were not run as part of this patch.

Codex Task

@multiplex55 multiplex55 merged commit 0e3cf5d into master Jan 8, 2026
1 check passed
@multiplex55 multiplex55 deleted the codex/update-macro-step-selection-for-bookmarks-and-folders branch January 9, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant